refactor: Unwrap a one-liner #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shpaass
force-pushed
the
unwrap-oneliner
branch
from
f611fde
to
dfd8bb7
Compare
|
Rebased on fresh master and changed a function name |
skullbearer
approved these changes
Oct 5, 2024
The idea was to make this part of code more readable. For this, the following steps were taken: 1. Split booleans into one equality or expression per boolean. 2. Explain with local names what the boolean conditions check. 3. Put on-select actions as a local function too. 4. Align parameters Google-style. QA: tested on a pY project that the corresponding window selects and deselects things as usual.
shpaass
force-pushed
the
unwrap-oneliner
branch
from
dfd8bb7
to
1690a77
Compare
|
Rebased on fresh master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea was to make this part of code more readable. For this, the following steps were taken:
I also added blank lines around some code blocks.
QA: tested on a pY project that the corresponding window selects and deselects things as usual.
This ticket is a part of #256. It doesn't fix it, but it works towards addressing it.